Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] optimize ray-data-resnet50-ingest-file-size-benchmark #43571

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

raulchen
Copy link
Contributor

Why are these changes needed?

there is a perf regression for those 2 small-sized test cases in ray-data-resnet50-ingest-file-size-benchmark, due to the new backpressure change (#43171).
Update some configs to fix the perf issue.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Hao Chen <chenh1024@gmail.com>
@bveeramani bveeramani self-assigned this Feb 29, 2024
@raulchen raulchen merged commit 1f36863 into ray-project:master Feb 29, 2024
9 checks passed
@raulchen raulchen deleted the optimize-resnet-ingest-test branch February 29, 2024 22:29
hebiao064 pushed a commit to hebiao064/ray that referenced this pull request Mar 12, 2024
there is a perf regression for those 2 small-sized test cases in ray-data-resnet50-ingest-file-size-benchmark, due to the new backpressure change (ray-project#43171).
Update some configs to fix the perf issue.

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants