Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Additional Ray Data Dashboard Metrics #43628

Merged
merged 22 commits into from
Mar 6, 2024
Merged

[Data] Additional Ray Data Dashboard Metrics #43628

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
c3615d4
add input/output queue metrics
scottjlee Mar 1, 2024
c15bf3b
Merge branch 'master' into 0229-dash-metrics
scottjlee Mar 1, 2024
7f3d7e2
add input related metrics
scottjlee Mar 3, 2024
ad5f80a
add task related metrics
scottjlee Mar 3, 2024
e93616b
add remaining metrics
scottjlee Mar 4, 2024
ad04cbb
tests
scottjlee Mar 4, 2024
edf90cb
Merge branch 'master' into 0229-dash-metrics
scottjlee Mar 4, 2024
1f6773b
update docs
scottjlee Mar 4, 2024
708ffe5
vale spelling
scottjlee Mar 4, 2024
a6d4ba9
additional spelling
scottjlee Mar 4, 2024
1eacbc8
group metrics into dict
scottjlee Mar 5, 2024
6b94ec1
generate panel from metric
scottjlee Mar 5, 2024
85cfb9b
group into sections
scottjlee Mar 5, 2024
2f777ca
Merge branch 'master' into 0229-dash-metrics
scottjlee Mar 5, 2024
26f09e0
move data import inside method
scottjlee Mar 5, 2024
f1a450f
Merge branch 'master' into 0229-dash-metrics
scottjlee Mar 5, 2024
361fd93
revert ray data import from dashboard, address comments
scottjlee Mar 5, 2024
4f497c3
Merge branch 'master' into 0229-dash-metrics
scottjlee Mar 5, 2024
f12885e
clean up
scottjlee Mar 6, 2024
a61bff9
Merge branch 'master' into 0229-dash-metrics
scottjlee Mar 6, 2024
115062b
deflake tests
scottjlee Mar 6, 2024
d7cb1ff
update op object store usage in update_usages
scottjlee Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vale/styles/Vocab/Data/accept.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
autoscaler
[Bb]ackpressure
Dask
Data('s)?
[Dd]atasource
Expand All @@ -7,10 +8,12 @@ dtype
[Gg]roupby
[Ii]ndexable
[Ii]ngest
[Ii]nqueue(s)?
[Ll]ookup(s)?
Modin
[Mm]ultiget(s)?
ndarray(s)?
[Oo]utqueue(s)?
Predibase('s)?
[Pp]refetch
[Pp]refetching
Expand Down
132 changes: 131 additions & 1 deletion dashboard/client/src/pages/metrics/Metrics.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ const METRICS_CONFIG: MetricsSectionConfig[] = [

const DATA_METRICS_CONFIG: MetricsSectionConfig[] = [
{
title: "Ray Data Metrics",
title: "Ray Data Metrics (Overview)",
contents: [
{
title: "Bytes Spilled",
Expand Down Expand Up @@ -208,10 +208,135 @@ const DATA_METRICS_CONFIG: MetricsSectionConfig[] = [
title: "Rows Outputted",
pathParams: "orgId=1&theme=light&panelId=11",
},
],
},
{
title: "Ray Data Metrics (Inputs)",
contents: [
{
title: "Input Blocks Received by Operator",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I assume the ordering of display is based on panelId? Should these be ordered by that for ~organization or is the order here important?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

panel id is actually unrelated to the order, the order directly follows the order of elements in this .tsx file. the only restriction is that panel id needs to be unique and matches the id from grafana panel

pathParams: "orgId=1&theme=light&panelId=17",
},
{
title: "Input Blocks Processed by Tasks",
pathParams: "orgId=1&theme=light&panelId=19",
},
{
title: "Input Bytes Processed by Tasks",
pathParams: "orgId=1&theme=light&panelId=20",
},
{
title: "Input Bytes Submitted to Tasks",
pathParams: "orgId=1&theme=light&panelId=21",
},
],
},
{
title: "Ray Data Metrics (Outputs)",
contents: [
{
title: "Blocks Generated by Tasks",
pathParams: "orgId=1&theme=light&panelId=22",
},
{
title: "Bytes Generated by Tasks",
pathParams: "orgId=1&theme=light&panelId=23",
},
{
title: "Rows Generated by Tasks",
pathParams: "orgId=1&theme=light&panelId=24",
},
{
title: "Output Blocks Taken by Downstream Operators",
pathParams: "orgId=1&theme=light&panelId=25",
},
{
title: "Output Bytes Taken by Downstream Operators",
pathParams: "orgId=1&theme=light&panelId=26",
},
{
title: "Output Blocks from Finished Tasks",
pathParams: "orgId=1&theme=light&panelId=27",
},
{
title: "Output Bytes from Finished Tasks",
pathParams: "orgId=1&theme=light&panelId=28",
},
],
},
{
title: "Ray Data Metrics (Tasks)",
contents: [
{
title: "Submitted Tasks",
pathParams: "orgId=1&theme=light&panelId=29",
},
{
title: "Running Tasks",
pathParams: "orgId=1&theme=light&panelId=30",
},
{
title: "Tasks with output blocks",
pathParams: "orgId=1&theme=light&panelId=31",
},
{
title: "Finished Tasks",
pathParams: "orgId=1&theme=light&panelId=32",
},
{
title: "Failed Tasks",
pathParams: "orgId=1&theme=light&panelId=33",
},
{
title: "Block Generation Time",
pathParams: "orgId=1&theme=light&panelId=8",
},
{
title: "Task Submission Backpressure Time",
pathParams: "orgId=1&theme=light&panelId=37",
},
],
},
{
title: "Ray Data Metrics (Object Store Memory)",
contents: [
{
title: "Operator Internal Inqueue Size (Blocks)",
pathParams: "orgId=1&theme=light&panelId=13",
},
{
title: "Operator Internal Inqueue Size (Bytes)",
pathParams: "orgId=1&theme=light&panelId=14",
},
{
title: "Operator Internal Outqueue Size (Blocks)",
pathParams: "orgId=1&theme=light&panelId=15",
},
{
title: "Operator Internal Outqueue Size (Bytes)",
pathParams: "orgId=1&theme=light&panelId=16",
},
{
title: "Size of Blocks used in Pending Tasks (Bytes)",
pathParams: "orgId=1&theme=light&panelId=34",
},
{
title: "Freed Memory in Object Store (Bytes)",
pathParams: "orgId=1&theme=light&panelId=35",
},
{
title: "Spilled Memory in Object Store (Bytes)",
pathParams: "orgId=1&theme=light&panelId=36",
},
],
},
{
title: "Ray Data Metrics (Iteration)",
contents: [
{
title: "Iteration Initialization Time",
pathParams: "orgId=1&theme=light&panelId=12",
},
{
title: "Iteration Blocked Time",
pathParams: "orgId=1&theme=light&panelId=9",
Expand All @@ -222,6 +347,11 @@ const DATA_METRICS_CONFIG: MetricsSectionConfig[] = [
},
],
},
// Add metrics with `metrics_group: "misc"` here.
// {
// title: "Ray Data Metrics (Miscellaneous)",
// contents: [],
// },
];

export const Metrics = () => {
Expand Down