Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Fix suboperator timing calculation #43802

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

omatthew98
Copy link
Contributor

Why are these changes needed?

#43790 Unearthed a bug with the calculation of time_total_s for suboperators, this fixes that bug by moving the calculation of the time to the top level of the from_block_metadata function.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Owen <mowen@anyscale.com>
@c21
Copy link
Contributor

c21 commented Mar 8, 2024

Seems test is failing. o.w. LGTM

Signed-off-by: Matthew Owen <mowen@anyscale.com>
@c21 c21 added the release-blocker P0 Issue that blocks the release label Mar 8, 2024
@raulchen raulchen merged commit d68ddc9 into ray-project:master Mar 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants