Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Release 2.10 fix for PPO on new API stack with multi-GPU. #44001

Merged
merged 2 commits into from Mar 14, 2024
Merged

[RLlib] Release 2.10 fix for PPO on new API stack with multi-GPU. #44001

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2201530
wip
sven1977 Mar 14, 2024
b8ff1a1
Merge branch 'releases/2.10.0' into rllib_fixes
sven1977 Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions rllib/core/rl_module/torch/torch_rl_module.py
View file
Open in desktop
Expand Up @@ -183,6 +183,13 @@ def _save_module_metadata(self, *args, **kwargs):
def _module_metadata(self, *args, **kwargs):
return self.unwrapped()._module_metadata(*args, **kwargs)

# TODO (sven): Figure out a better way to avoid having to method-spam this wrapper
# class, whenever we add a new API to any wrapped RLModule here. We could try
# auto generating the wrapper methods, but this will bring its own challenge
# (e.g. recursive calls due to __getattr__ checks, etc..).
def _compute_values(self, *args, **kwargs):
return self.unwrapped()._compute_values(*args, **kwargs)

@override(RLModule)
def unwrapped(self) -> "RLModule":
return self.module
Expand Down