Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Remove 'Using Preprocessors' #44006

Merged
merged 1 commit into from Mar 14, 2024
Merged

[Data] Remove 'Using Preprocessors' #44006

merged 1 commit into from Mar 14, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

We typically don't recommend people use Preprocessor anymore. So, this PR removes the "Using Preprocessors" user guide.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Remove 'Using Preprocessors'
021bf68 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
justinvyu
justinvyu approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch on the ray data guide which was a bit outdated.

@bveeramani bveeramani merged commit 123b87c into ray-project:master Mar 14, 2024
9 checks passed
@bveeramani bveeramani deleted the removing-preprocessors branch March 14, 2024 19:52
angelinalg
angelinalg reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to make the recommendation more forceful.

doc/source/train/user-guides/data-loading-preprocessing.rst
@@ -510,7 +510,7 @@ Preprocessing structured data
This section is for tabular/structured data. The recommended way for preprocessing unstructured data is to use
Ray Data operations such as `map_batches`. See the :ref:`Ray Data Working with Pytorch guide <working_with_pytorch>` for more details.

For tabular data, we recommend using Ray Data :ref:`preprocessors <data-preprocessors>`, which implement common data preprocessing operations.
For tabular data, we recommend using Ray Data :ref:`preprocessors <preprocessor-ref>`, which implement common data preprocessing operations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tabular data, use Ray Data :ref:preprocessors <preprocessor-ref>, which implement common data preprocessing operations.

bveeramani added a commit to bveeramani/ray that referenced this pull request Mar 15, 2024
@bveeramani
[Data] Remove 'Using Preprocessors' (ray-project#44006)
bf6b096 
We typically don't recommend people use Preprocessor anymore. So, this PR removes the "Using Preprocessors" user guide.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani mentioned this pull request Mar 15, 2024
Merged
8 tasks
khluu pushed a commit that referenced this pull request Mar 15, 2024
@bveeramani
[Data] Remove 'Using Preprocessors' (#44006) (#44042)
4a7c71c 
Cherry-pick of #44006.
We typically don't recommend people use Preprocessor anymore. So, this PR removes the "Using Preprocessors" user guide.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani mentioned this pull request Mar 18, 2024
Merged
8 tasks
bveeramani added a commit that referenced this pull request Mar 19, 2024
@bveeramani
[Train] Revise recommendation to use preprocessors (#44099)
440f2c0 
#44006 (review)

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
stephanie-wang pushed a commit to stephanie-wang/ray that referenced this pull request Mar 27, 2024
@bveeramani @stephanie-wang
[Train] Revise recommendation to use preprocessors (ray-project#44099)
7913eb8 
ray-project#44006 (review)

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelinalg angelinalg angelinalg left review comments

@justinvyu justinvyu justinvyu approved these changes

@c21 c21 c21 approved these changes

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees

@justinvyu justinvyu

@c21 c21

@angelinalg angelinalg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bveeramani @justinvyu @c21 @angelinalg