Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Revise batch inference user guide #44007

Merged
merged 6 commits into from Mar 15, 2024
Merged

[Data] Revise batch inference user guide #44007

merged 6 commits into from Mar 15, 2024

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Mar 14, 2024 •
edited

Why are these changes needed?

This PR fixes typo and condenses the batch inference user guide.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Update file
f0fe708 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
c21
c21 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting pending the fix for CI issues.

@bveeramani
Stuff
4fc57c9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update files
bac5687 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Fix
137a58e 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
matthewdeng
matthewdeng approved these changes Mar 14, 2024
View reviewed changes
doc/source/train/user-guides/results.rst Outdated Show resolved Hide resolved
@bveeramani
address review comments
198dbaa 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Fix typo
927d1a1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani merged commit f319473 into ray-project:master Mar 15, 2024
9 checks passed
bveeramani added a commit to bveeramani/ray that referenced this pull request Mar 15, 2024
@bveeramani
[Data] Revise batch inference user guide (ray-project#44007)
aac8f46 
This PR fixes typo and condenses the batch inference user guide.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani mentioned this pull request Mar 15, 2024
Merged
8 tasks
khluu pushed a commit that referenced this pull request Mar 15, 2024
@bveeramani
[Data] Revise batch inference user guide (#44007) (#44041)
9e2ebea 
Cherry-pick of #44007

This PR fixes typo and condenses the batch inference user guide.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

@c21 c21 c21 approved these changes

@scottjlee scottjlee scottjlee approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

@justinvyu justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

Assignees

@c21 c21

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bveeramani @matthewdeng @c21 @scottjlee