Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data] turn off actor locality by default #44123

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

raulchen
Copy link
Contributor

Why are these changes needed?

#43463 was supposed to introduce this change.
But I made a mistake while resolving conflicts with master before merging the PR.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Copy link
Contributor

@scottjlee scottjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock merge

@raulchen
Copy link
Contributor Author

we've manually run release tests with this change before #43463 (comment)
It should be safe to merge.

@raulchen raulchen changed the title [data] turn of actor locality by default [data] turn off actor locality by default Mar 19, 2024
khluu pushed a commit that referenced this pull request Mar 19, 2024
Cherry-pick #44123

Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen merged commit a28dfdd into ray-project:master Mar 19, 2024
4 of 5 checks passed
@raulchen raulchen deleted the turn-off-actor-locality branch March 19, 2024 19:47
stephanie-wang pushed a commit to stephanie-wang/ray that referenced this pull request Mar 27, 2024
Signed-off-by: Hao Chen <chenh1024@gmail.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants