Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Fix throughput time calculations #44138

Merged
merged 13 commits into from
Mar 26, 2024
Merged

[Data] Fix throughput time calculations #44138

merged 13 commits into from
Mar 26, 2024

Commits on Mar 21, 2024

  1. fix throughput time calculations 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    7c95ee4 View commit details
    Browse the repository at this point in the history

  2. update the throughput calculation further, add comments to document 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    327169f View commit details
    Browse the repository at this point in the history

  3. fix bugs 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    363d4ff View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. refactor to use collect dataset stats summaries fn 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    aa29bdd View commit details
    Browse the repository at this point in the history

  2. fix existing test 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e2a21c8 View commit details
    Browse the repository at this point in the history

  3. adding in test for total time all blocks 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    9530448 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. fixing logic for runtime metrics (do not use sum) 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    b3201fa View commit details
    Browse the repository at this point in the history

  2. fix bug, simplify method 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    55c1e1c View commit details
    Browse the repository at this point in the history

  3. adding in sanity check test for throughput 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    9587fde View commit details
    Browse the repository at this point in the history

  4. adding in test for runtime 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    39f1b85 View commit details
    Browse the repository at this point in the history

  5. fix bug for test_sort 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    436cda3 View commit details
    Browse the repository at this point in the history

  6. respond to pr feedback 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    38804a5 View commit details
    Browse the repository at this point in the history

  7. fix lint for robocop 

    Signed-off-by: Matthew Owen <mowen@anyscale.com>
    @omatthew98
    omatthew98 committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e1e1678 View commit details
    Browse the repository at this point in the history