[RLlib] MultiAgentEpisode add module_for API.
#44241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i_agent_episode_add_module_for_api
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla,
kouroshHakha and
simonsays1980
as code owners
simonsays1980
approved these changes
Mar 22, 2024
| @@ -177,6 +177,11 @@ def __init__( | |||
| AlgorithmConfig.DEFAULT_AGENT_TO_MODULE_MAPPING_FN | |||
| ) | |||
| self.agent_to_module_mapping_fn = agent_to_module_mapping_fn | |||
| # In case a user - e.g. via callbacks - already forces a mapping to happen | |||
| # via the `module_for()` API even before the agent has entered the episode | |||
| # (and has its SingleAgentEpisode created), we store all aldeary done mappings | |||
There was a problem hiding this comment.
"aldeary" -> "already"
stephanie-wang
pushed a commit
to stephanie-wang/ray
that referenced
this pull request
Mar 27, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiAgentEpisodeaddmodule_for([agent ID])API.Users currently have no means to trigger an agent-to-module mapping within a MultiAgentEpisode before the agent has entered the episode (has its SingleAgentEpisode created).
A new API:
MultiAgentEpisode.module_for(analogous to the oldEpisode(V2).policy_for()API) fixes this issue.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.