[RLlib] AlgorithmConfig cleanup 02: Restructure methods and properties. #44896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
added
rllib
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla,
kouroshHakha,
simonsays1980 and
a team
as code owners
…rithm_config_cleanup_02_restructure_methods Signed-off-by: sven1977 <svenmika1977@gmail.com> # Conflicts: # rllib/examples/evaluation/evaluation_parallel_to_training.py
simonsays1980
approved these changes
Apr 25, 2024
| @@ -29,7 +29,7 @@ def get(self): | |||
| # __rllib-adv_api_explore_begin__ | |||
| from ray.rllib.algorithms.algorithm_config import AlgorithmConfig | |||
|
|
|||
| config = AlgorithmConfig().exploration( | |||
There was a problem hiding this comment.
Isn't rollout a typically used name in RL for rolling out the policy for sampling?
There was a problem hiding this comment.
Totally, but I felt like some of these settings in here are less concerned about the rollout process itself, but more about how the EnvRunner (that performs these rollouts) is set up. Let me think about it again a bit ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlgorithmConfig cleanup 02: Restructure methods and properties:
rollouts()intoenv_runners().exploration()intoenv_runners(explore=.., exploration_config=..).num_rollout_workers->num_env_runners,num_envs_per_worker->num_envs_per_env_runner, etc..\@OldAPIStack.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.