Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix broken references in data documentation #44956

Merged
merged 1 commit into from
Apr 30, 2024
Merged

[Doc] Fix broken references in data documentation #44956

merged 1 commit into from
Apr 30, 2024

Conversation

peytondmurray
Copy link
Contributor

Why are these changes needed?

This PR fixes some bad references in Ray Data.

Related issue number

Partially addresses #39658.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@peytondmurray peytondmurray force-pushed the docs-fix-data-bad-links-39658 branch 2 times, most recently from 3c2b983 to 45781cf Compare April 24, 2024 23:12
@peytondmurray peytondmurray marked this pull request as ready for review April 24, 2024 23:13
@peytondmurray peytondmurray added the docs An issue or change related to documentation label Apr 24, 2024
@anyscalesam anyscalesam added triage Needs triage (eg: priority, bug/not-bug, and owning component) data Ray Data-related issues labels Apr 26, 2024
@peytondmurray peytondmurray changed the title [Doc] Fix bad references in data [Doc] Fix broken references in data documentation Apr 29, 2024
@peytondmurray peytondmurray removed the triage Needs triage (eg: priority, bug/not-bug, and owning component) label Apr 29, 2024
bveeramani
bveeramani approved these changes Apr 29, 2024
View reviewed changes
python/ray/data/datasource/datasource.py Show resolved Hide resolved
python/ray/data/iterator.py Outdated Show resolved Hide resolved
@peytondmurray
[Doc] Fix bad references in data
6d38413 
Signed-off-by: pdmurray <peynmurray@gmail.com>
@aslonnie aslonnie merged commit 145c15b into ray-project:master Apr 30, 2024
5 checks passed
@peytondmurray peytondmurray deleted the docs-fix-data-bad-links-39658 branch April 30, 2024 16:18
harborn pushed a commit to harborn/ray that referenced this pull request May 8, 2024
@peytondmurray @harborn
[Doc] Fix broken references in data documentation (ray-project#44956)
6d79f5d 
 fixes some bad references in Ray Data.
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
@peytondmurray @ryanaoleary
[Doc] Fix broken references in data documentation (ray-project#44956)
348ea2e 
 fixes some bad references in Ray Data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bveeramani bveeramani bveeramani approved these changes

@aslonnie aslonnie aslonnie approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@c21 c21 Awaiting requested review from c21 c21 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees
No one assigned
Labels
data Ray Data-related issues docs An issue or change related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peytondmurray @bveeramani @aslonnie @anyscalesam