[Data] Deprecate prefetch_batches arg of iter_rows and change default value
#44982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
bveeramani
changed the title
prefetch_batches arg of iter_rows and change default value
c21
approved these changes
Apr 26, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…ault value (ray-project#44982) This PR deprecates the `prefetch_batches` parameter of `Dataset.iter_rows` because it leaks an implementation detail (namely, that we use `Dataset.iter_batches` under-the-hood). This PR also increases the default value for 1) consistency with `iter_batches` and 2) to improve performance. For historical context, ray-project#43349 erroneously introduced the `prefetch_batches` parameter. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR deprecates the
prefetch_batchesparameter ofDataset.iter_rowsbecause it leaks an implementation detail (namely, that we useDataset.iter_batchesunder-the-hood). This PR also increases the default value for 1) consistency withiter_batchesand 2) to improve performance.For historical context, #43349 erroneously introduced the
prefetch_batchesparameter.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.