Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix test case test_envs_that_crash. #44989

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Apr 26, 2024

Fix test case test_envs_that_crash.

Broken due to

  • new AlgorithmConfig settings (some were recently renamed).
  • Noticed that ignore_env_runner_failures (fka ignore_worker_failures) was NOT settable via any method of AlgorithmConfig (property had to be set manually since at least a few ray releases). Fixed now.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No much change mainly renaming.

@sven1977 sven1977 merged commit 0e8ef33 into ray-project:master Apr 26, 2024
5 checks passed
@sven1977 sven1977 deleted the fix_test_case_envs_that_crash branch April 26, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants