[RLlib] Cleanup ActorManager and WorkerSet: Make all mark_healthy/healthy_only method args True by default.
#44993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla,
kouroshHakha and
simonsays1980
as code owners
sven1977
added
the
tests-ok
simonsays1980
approved these changes
Apr 27, 2024
| timeout_seconds=self.config.worker_restore_timeout_s, | ||
| # Bring back actor after successful state syncing. | ||
| mark_healthy=True, | ||
| timeout_seconds=self.config.env_runner_restore_timeout_s, |
There was a problem hiding this comment.
Does this timeout and restoration time in general influence in any way the sampling (blocking it or slowing down for example)? I ask b/c in this case the sample_timeout_s could lead to no samples returned by synchronous_parallel_sample and lead to errors.
| env_runner_health_probe_timeout_s: Max amount of time we should spend | ||
| waiting for health probe calls to finish. Health pings are very cheap, | ||
| so the default is 1 minute. | ||
| env_runner_health_probe_timeout_s: Max amount of time in seconds, we should |
There was a problem hiding this comment.
Here as well: Any influence on/by sample_timeout_s?
Signed-off-by: Sven Mika <svenmika1977@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…y`/`healthy_only` method args `True` by default. (ray-project#44993)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup
ActorManagerandWorkerSet: Make allmark_healthy/healthy_onlymethod argsTrueby default.Also renamed
WorkerSet.__actor_managernot super-private anymore (super-privates make it impossible to debug properly!).Reasoning:
The default behavior of a
WorkerSet.foreach_...call should be:timeout(sometimes a minute) for workers that we already know are NOT healthy.mark_healthyshould always be True anyways! If any worker that is being sent q request - for whatever reason - then responds properly, we should mark it healthy, unless there is a good reason NOT to do so.restore_workersAPI. This method will send a special "ping" request to all unhealthy (only) workers (with a now shortened timeout of 30sec (before 60s)) and mark them healthy, if they respond well.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.