Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Use DEFAULT_MODULE_ID instead of DEFAULT_POLICY_ID everywhere on new API stack. #45022

Merged
merged 5 commits into from
Apr 29, 2024
Merged

[RLlib] Use DEFAULT_MODULE_ID instead of DEFAULT_POLICY_ID everywhere on new API stack. #45022

merged 5 commits into from
Apr 29, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Apr 28, 2024 •
edited

Use DEFAULT_MODULE_ID instead of DEFAULT_POLICY_ID everywhere on new API stack.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
ac49e43 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 marked this pull request as ready for review April 28, 2024 16:51
@sven1977
LINT
a775f09 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
aslonnie
aslonnie approved these changes Apr 28, 2024
View reviewed changes
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve for docs.

@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into use_…
4afbe59 
…default_module_id_instead_of_default_policy_id
@sven1977
wip
7c2f4e8 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
simonsays1980
simonsays1980 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FInally this DEFAULT_POLICY_ID relict is releasd from its duties :)

@sven1977
wip
d92da76 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 merged commit 8b41666 into ray-project:master Apr 29, 2024
5 checks passed
@sven1977 sven1977 deleted the use_default_module_id_instead_of_default_policy_id branch April 29, 2024 14:24
harborn pushed a commit to harborn/ray that referenced this pull request May 8, 2024
@sven1977 @harborn
[RLlib] Use DEFAULT_MODULE_ID instead of DEFAULT_POLICY_ID everywhere…
c3c5002 
… on new API stack. (ray-project#45022)
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
@sven1977 @ryanaoleary
[RLlib] Use DEFAULT_MODULE_ID instead of DEFAULT_POLICY_ID everywhere…
04c90ce 
… on new API stack. (ray-project#45022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@aslonnie aslonnie aslonnie approved these changes

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst ArturNiederfahrenhorst is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

Assignees

@simonsays1980 simonsays1980

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sven1977 @simonsays1980 @aslonnie