[RLlib] Fix CI test: examples/checkpoints/checkpoint_by_custom_criteria.py
#45030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… grid. Signed-off-by: Simon Zehnder <simon.zehnder@gmail.com>
sven1977
reviewed
Apr 29, 2024
| @@ -111,7 +111,11 @@ | |||
| ) | |||
|
|
|||
| # Confirm, we picked the right trial. | |||
| assert value_best_metric == results.get_dataframe()[metric].min() | |||
|
|
|||
| assert ( | |||
There was a problem hiding this comment.
Nice!! Thanks for the fix @simonsays1980 !
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla and
kouroshHakha
as code owners
sven1977
changed the title
examples/checkpoints/checkpoint_by_custom_criteria.py
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
May 8, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR fixes a small error in the
checkpoint_by_custom_criteria.pyexample. We needed to filter the result grid before applying the minimum.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.