Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] ray.init(logging_format) argument is ignored #45037

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Apr 29, 2024

Why are these changes needed?

#32741 accidentally removes the logging_format parameter from the setup_logging function. This PR overwrites the formatters for all default handlers.

Related issue number

Closes #44713

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(
Screenshot 2024-04-29 at 12 43 30 PM

Signed-off-by: kaihsun <kaihsun@anyscale.com>
Copy link
Contributor

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, let's add a test so we don't have regression in the future.

Signed-off-by: kaihsun <kaihsun@anyscale.com>
@kevin85421
Copy link
Member Author

Code lgtm, let's add a test so we don't have regression in the future.

Add a test 82e1018.

Screenshot 2024-04-29 at 9 43 26 PM

Signed-off-by: kaihsun <kaihsun@anyscale.com>
@jjyao jjyao merged commit 33bde4c into ray-project:master Apr 30, 2024
5 checks passed
harborn pushed a commit to harborn/ray that referenced this pull request May 8, 2024
ray-project#32741 accidentally removes the logging_format parameter from the setup_logging function. This PR overwrites the formatters for all default handlers.

Signed-off-by: kaihsun <kaihsun@anyscale.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
ray-project#32741 accidentally removes the logging_format parameter from the setup_logging function. This PR overwrites the formatters for all default handlers.

Signed-off-by: kaihsun <kaihsun@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] ray.init(logging_format) argument is ignored
3 participants