[Data] Don't load Arrow PyExtensionType by default
#45084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Comment on lines
+178
to
+181
| "Reading data written with older versions of Ray might expose you to " | ||
| "arbitrary code execution. To try reading the data anyway, set " | ||
| "`RAY_DATA_AUTOLOAD_PYEXTENSIONTYPE=1` on all nodes." | ||
| "To learn more, see https://github.com/ray-project/ray/issues/41314." |
There was a problem hiding this comment.
I find this message slightly confusing (or underselling the risk). It's not only data "written with older versions of Ray" that might expose the user, it's reading any random Parquet file that will expose the user if you enabled this RAY_DATA_AUTOLOAD_PYEXTENSIONTYPE=1 and have imported Ray
can-anyscale
pushed a commit
that referenced
this pull request
May 7, 2024
Loading PyExtensionType types can expose you to arbitrary code execution. To avoid exposing users to this vulnerability, this PR disables loading PyExtensionType by default. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
May 8, 2024
Loading PyExtensionType types can expose you to arbitrary code execution. To avoid exposing users to this vulnerability, this PR disables loading PyExtensionType by default. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
May 13, 2024
Loading PyExtensionType types can expose you to arbitrary code execution. To avoid exposing users to this vulnerability, this PR disables loading PyExtensionType by default. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
Loading PyExtensionType types can expose you to arbitrary code execution. To avoid exposing users to this vulnerability, this PR disables loading PyExtensionType by default. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
Loading PyExtensionType types can expose you to arbitrary code execution. To avoid exposing users to this vulnerability, this PR disables loading PyExtensionType by default. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Loading
PyExtensionTypetypes can expose you to arbitrary code execution. To avoid exposing users to this vulnerability, this PR disables loadingPyExtensionTypeby default.Related issue number
Fixes #41314
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.