[Serve] fix control+c after serve run doesn't shutdown serve components
#45087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gene Su <e870252314@gmail.com>
Signed-off-by: Gene Su <e870252314@gmail.com>
edoakes
approved these changes
May 2, 2024
| @@ -964,5 +964,27 @@ def test_serve_run_mount_to_correct_deployment_route_prefix(ray_start_stop): | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(sys.platform == "win32", reason="File path incorrect on Windows.") | |||
| def test_control_c_shutdown_serve_components(ray_start_stop): | |||
There was a problem hiding this comment.
I presume you tested that this fails w/o your change?
There was a problem hiding this comment.
yep, I purposely push a commit with just the test trying to see this failing in CI with the serve component still alive as well https://buildkite.com/ray-project/premerge/builds/25316#018f3652-b00a-45a2-aadc-ca46fb8d4f5d/182-3706
Signed-off-by: Gene Su <e870252314@gmail.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
May 8, 2024
…ents (ray-project#45087) Added a test to ensure this is captured and fix it.
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
May 13, 2024
…ents (ray-project#45087) Added a test to ensure this is captured and fix it. Signed-off-by: pdmurray <peynmurray@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…ents (ray-project#45087) Added a test to ensure this is captured and fix it. Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…ents (ray-project#45087) Added a test to ensure this is captured and fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Added a test to ensure this is captured and fix it.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.