Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated modules #45104

Merged
merged 1 commit into from
May 2, 2024
Merged

remove deprecated modules #45104

merged 1 commit into from
May 2, 2024

Conversation

st--
Copy link
Contributor

@st-- st-- commented May 2, 2024

Why are these changes needed?

#36984 removed warn_structure_refactor, but failed to remove the ray.air.callbacks submodules that still rely on it. While arguably in my specific case the presence of their remainder helped me update some old code, it would be cleaner if ray failed with an ImportError, making it clear that it's an issue on the user side, rather than something that looks like it's a bug.

Related issue number

Closes #45103

Checks

This PR only removes no-longer-used modules, and does not add any new code.

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [-] I've run scripts/format.sh to lint the changes in this PR.
  • [-] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [-] I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • [-] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [-] Unit tests
    • [-] Release tests
    • [-] This PR is not tested :(

@st--
remove deprecated modules
8d96048 
Signed-off-by: ST John <st--@users.noreply.github.com>
matthewdeng
matthewdeng approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@matthewdeng matthewdeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

@matthewdeng matthewdeng merged commit ab5871b into ray-project:master May 2, 2024
5 checks passed
@st-- st-- deleted the st/remove_deprecated branch May 6, 2024 10:57
harborn pushed a commit to harborn/ray that referenced this pull request May 8, 2024
@st-- @harborn
[tune] remove deprecated ray.air.callbacks modules (ray-project#45104)
fc9f0f4 
ray-project#36984 removed
`warn_structure_refactor`, but failed to remove the `ray.air.callbacks`
submodules that still rely on it. While arguably in my specific case the
presence of their remainder helped me update some old code, it would be
cleaner if ray failed with an ImportError, making it clear that it's an
issue on the user side, rather than something that looks like it's a
bug.

Signed-off-by: ST John <st--@users.noreply.github.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request May 13, 2024
@st-- @peytondmurray
[tune] remove deprecated ray.air.callbacks modules (ray-project#45104)
c113d61 
ray-project#36984 removed
`warn_structure_refactor`, but failed to remove the `ray.air.callbacks`
submodules that still rely on it. While arguably in my specific case the
presence of their remainder helped me update some old code, it would be
cleaner if ray failed with an ImportError, making it clear that it's an
issue on the user side, rather than something that looks like it's a
bug.

Signed-off-by: ST John <st--@users.noreply.github.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
@st-- @ryanaoleary
[tune] remove deprecated ray.air.callbacks modules (ray-project#45104)
83083fd 
ray-project#36984 removed
`warn_structure_refactor`, but failed to remove the `ray.air.callbacks`
submodules that still rely on it. While arguably in my specific case the
presence of their remainder helped me update some old code, it would be
cleaner if ray failed with an ImportError, making it clear that it's an
issue on the user side, rather than something that looks like it's a
bug.

Signed-off-by: ST John <st--@users.noreply.github.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
@st-- @ryanaoleary
[tune] remove deprecated ray.air.callbacks modules (ray-project#45104)
942f0d0 
ray-project#36984 removed
`warn_structure_refactor`, but failed to remove the `ray.air.callbacks`
submodules that still rely on it. While arguably in my specific case the
presence of their remainder helped me update some old code, it would be
cleaner if ray failed with an ImportError, making it clear that it's an
issue on the user side, rather than something that looks like it's a
bug.

Signed-off-by: ST John <st--@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewdeng matthewdeng matthewdeng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@st-- @matthewdeng