[RLlib] Fix 2 broken CI test cases: test_learner_group and cartpole_dqn_envrunner.
#45110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla,
kouroshHakha and
simonsays1980
as code owners
simonsays1980
approved these changes
May 2, 2024
| @@ -274,7 +274,7 @@ def _sample_timesteps( | |||
| if explore: | |||
| env_steps_lifetime = self.metrics.peek( | |||
| NUM_ENV_STEPS_SAMPLED_LIFETIME | |||
There was a problem hiding this comment.
NUM_ENV_STEPS_SAMPLED_LIFETIME is then update during synching the metrics in between sampling?
There was a problem hiding this comment.
Correct, it's always updated anyways (this was a bug) after each single env step. Inside self._increase_sampled_metrics().
There was a problem hiding this comment.
And it's also hard-overwritten by the Algo itself after each iteration in order to sum up all the steps from all the other EnvRunners (making sure each EnvRunner always has the total steps sampled, not just its own lifetime count).
This was referenced May 2, 2024
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
May 8, 2024
…e_dqn_envrunner`. (ray-project#45110)
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
May 13, 2024
…e_dqn_envrunner`. (ray-project#45110) Signed-off-by: pdmurray <peynmurray@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…e_dqn_envrunner`. (ray-project#45110) Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…e_dqn_envrunner`. (ray-project#45110)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 2 broken CI test cases:
test_learner_groupandcartpole_dqn_envrunner.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.