[serve] Fix controller recovery bug #45118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcin
force-pushed
the
pr45118
branch
2 times, most recently
from
3ae8510
to
6ff97fd
Compare
shrekris-anyscale
approved these changes
May 2, 2024
anyscalesam
added
bug
When controller recovers and there are autoscaling deployments whose configs don't have `initial_replicas` set, controller recover fails because of this bug. I've fixed the bug and added a test for it. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
May 8, 2024
[serve] Fix controller recovery bug When controller recovers and there are autoscaling deployments whose configs don't have `initial_replicas` set, controller recover fails because of this bug. I've fixed the bug and added a test for it. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
May 13, 2024
[serve] Fix controller recovery bug When controller recovers and there are autoscaling deployments whose configs don't have `initial_replicas` set, controller recover fails because of this bug. I've fixed the bug and added a test for it. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
[serve] Fix controller recovery bug When controller recovers and there are autoscaling deployments whose configs don't have `initial_replicas` set, controller recover fails because of this bug. I've fixed the bug and added a test for it. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
[serve] Fix controller recovery bug When controller recovers and there are autoscaling deployments whose configs don't have `initial_replicas` set, controller recover fails because of this bug. I've fixed the bug and added a test for it. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com> Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[serve] Fix controller recovery bug
When controller recovers and there are autoscaling deployments whose configs don't have
initial_replicasset, controller recover fails because of this bug.I've fixed the bug and added a test for it.
Signed-off-by: Cindy Zhang cindyzyx9@gmail.com