-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data] Fix Ray databricks UC reader with dynamic Databricks notebook scope token #45153
Merged
c21
merged 2 commits into
ray-project:master
from
WeichenXu123:fix-databricks-sql-reader
May 12, 2024
Merged
[Data] Fix Ray databricks UC reader with dynamic Databricks notebook scope token #45153
c21
merged 2 commits into
ray-project:master
from
WeichenXu123:fix-databricks-sql-reader
May 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@WeichenXu123 @c21 do we have a test for this reader? |
Yes, see |
The PR is ready for reviewing. @raulchen |
CC @c21 |
c21
approved these changes
May 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…scope token (ray-project#45153) Set Ray databricks UC reader token by header `Authorization: Bearer` instead of `requests.post` auth param. This fixes bugs on databricks dynamic token. Signed-off-by: Weichen Xu <weichen.xu@databricks.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…scope token (ray-project#45153) Set Ray databricks UC reader token by header `Authorization: Bearer` instead of `requests.post` auth param. This fixes bugs on databricks dynamic token. Signed-off-by: Weichen Xu <weichen.xu@databricks.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…scope token (ray-project#45153) Set Ray databricks UC reader token by header `Authorization: Bearer` instead of `requests.post` auth param. This fixes bugs on databricks dynamic token. Signed-off-by: Weichen Xu <weichen.xu@databricks.com>
GabeChurch
pushed a commit
to GabeChurch/ray
that referenced
this pull request
Jun 11, 2024
…scope token (ray-project#45153) Set Ray databricks UC reader token by header `Authorization: Bearer` instead of `requests.post` auth param. This fixes bugs on databricks dynamic token. Signed-off-by: Weichen Xu <weichen.xu@databricks.com> Signed-off-by: gchurch <gabe1church@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Set Ray databricks UC reader token by header
Authorization: Bearer
instead ofrequests.post
auth param.This fixes bugs on databricks dynamic token.
Testing code:
Result:
Before:
![image](https://private-user-images.githubusercontent.com/19235986/328464827-e7b3c1ca-62dd-4a51-95c0-11ff8390086d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MjYyMjEsIm5iZiI6MTcxOTYyNTkyMSwicGF0aCI6Ii8xOTIzNTk4Ni8zMjg0NjQ4MjctZTdiM2MxY2EtNjJkZC00YTUxLTk1YzAtMTFmZjgzOTAwODZkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDAxNTIwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTYxZTBlYWJmYmQ4MWM5ZDM2Njg4MGFmZTJhM2Y3ZDc0YTI5M2Y0Njk1ZmRmYzhlOWU0NGFjNDYwN2Q0YzdlZTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.uJcbjsAidRahV2k5EmXCyC5s93LNREkzhoqsjuuA6n4)
After:
![image](https://private-user-images.githubusercontent.com/19235986/328465201-7135a344-2971-4653-91b8-867087d213b0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MjYyMjEsIm5iZiI6MTcxOTYyNTkyMSwicGF0aCI6Ii8xOTIzNTk4Ni8zMjg0NjUyMDEtNzEzNWEzNDQtMjk3MS00NjUzLTkxYjgtODY3MDg3ZDIxM2IwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDAxNTIwMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU5ZjE0MDk1MWU2MmM0NmIxMzYxOWYzZjMxNDQyYjVmZDQxYWY4ZDY0MDc1YzdkYWU0NWU5M2ExMzk1YTBiOTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2RrsLfhuuN7Sj2Ecp0uI1BgmebVABFusDLJuaDul1H0)
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.