-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data][Train] Allow manually setting resource limits for training jobs #45188
[Data][Train] Allow manually setting resource limits for training jobs #45188
Conversation
Signed-off-by: Hao Chen <chenh1024@gmail.com>
Signed-off-by: Hao Chen <chenh1024@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Hao!
Two questions here:
- currently it seems only support excluding num_gpu and num_cpu, how could we ensure that those excluded gpus and cpus are colocated? (instead of excluding x cpu per node)
- Is it a good idea to provide a flag for the train users to exclude all resources of the training nodes?
Data scheduler doesn't distinguish the resources by nodes right now. It only looks at the global resource usage.
This is a good idea, I found it useful as well. But to do that, we also need to config training worker resource to take all resources from the training nodes. Otherwise, data tasks will still be scheduled on the training nodes. we can discuss more later. |
ray-project#45188) Previously it's not possible to manually set data resource limits for training jobs. Because we automatically set "exclude_resources" for training jobs, and "exclude_resources" and "resource_limits" cannot be both set. This PR fixes this issue by not automatically setting "exclude_resources" when "resource_limits" are already set by the user --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
ray-project#45188) Previously it's not possible to manually set data resource limits for training jobs. Because we automatically set "exclude_resources" for training jobs, and "exclude_resources" and "resource_limits" cannot be both set. This PR fixes this issue by not automatically setting "exclude_resources" when "resource_limits" are already set by the user --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
ray-project#45188) Previously it's not possible to manually set data resource limits for training jobs. Because we automatically set "exclude_resources" for training jobs, and "exclude_resources" and "resource_limits" cannot be both set. This PR fixes this issue by not automatically setting "exclude_resources" when "resource_limits" are already set by the user --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
ray-project#45188) Previously it's not possible to manually set data resource limits for training jobs. Because we automatically set "exclude_resources" for training jobs, and "exclude_resources" and "resource_limits" cannot be both set. This PR fixes this issue by not automatically setting "exclude_resources" when "resource_limits" are already set by the user --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ray-project#45188) Previously it's not possible to manually set data resource limits for training jobs. Because we automatically set "exclude_resources" for training jobs, and "exclude_resources" and "resource_limits" cannot be both set. This PR fixes this issue by not automatically setting "exclude_resources" when "resource_limits" are already set by the user --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ray-project#45188) Previously it's not possible to manually set data resource limits for training jobs. Because we automatically set "exclude_resources" for training jobs, and "exclude_resources" and "resource_limits" cannot be both set. This PR fixes this issue by not automatically setting "exclude_resources" when "resource_limits" are already set by the user --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
ray-project#45188) Previously it's not possible to manually set data resource limits for training jobs. Because we automatically set "exclude_resources" for training jobs, and "exclude_resources" and "resource_limits" cannot be both set. This PR fixes this issue by not automatically setting "exclude_resources" when "resource_limits" are already set by the user --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: gchurch <gabe1church@gmail.com>
Why are these changes needed?
Previously it's not possible to manually set data resource limits for training jobs.
Because we automatically set "exclude_resources" for training jobs, and "exclude_resources" and "resource_limits" cannot be both set.
This PR fixes this issue by not automatically setting "exclude_resources" when "resource_limits" are already set by the user
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.