[Core] Fix worker crash when getting actor name from runtime context

[982945902]

Why are these changes needed?

Currently calling get_runtime_context().get_actor_name() from driver will crash. Instead of crashing, this PR returns None in this case.

Related issue number

Closes #45174

Checks

• I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
• I've run scripts/format.sh to lint the changes in this PR.
• I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've added any new APIs to the API Reference. For example, if I added a
    method in Tune, I've added it in doc/source/tune/api/ under the
    corresponding .rst file.
• I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
• Testing Strategy
  • Unit tests
  • Release tests
  • This PR is not tested :(

[kevin85421]

How about updating runtime_context.py instead of core_worker.cc to keep the behavior consistent with other functions such as get_task_id and get_actor_id?

To elaborate,

    def get_actor_name(self) -> Optional[str]:
        """Get the current actor name of this worker.

        This shouldn't be used in a driver process.
        The name is in string format.

        Returns:
            The current actor name of this worker.
            If a current worker is an actor, and
            if actor name doesn't exist, it returns an empty string.
            If a current worker is not an actor, it returns None.
        """
        # only worker mode has actor_id
        if self.worker.mode != ray._private.worker.WORKER_MODE:
            logger.warning(
                "This method is only available when the process is a "
                f"worker. Current mode: {self.worker.mode}"
            )
            return None <---- Add this line
        actor_id = self.worker.actor_id
        return self.worker.actor_name if not actor_id.is_nil() else None

You can refer to get_task_id as an example.

[982945902]

@kevin85421 that good !

[kevin85421]

Would you mind adding a test in test_runtime_context.py? Btw, you can add -s in your git commit command to avoid the DCO failure in CI.

[982945902]

@kevin85421 ok

[aslonnie]

this line change is unrelated? could you rebase properly?

[982945902]

ok

[982945902]

https://github.com/ray-project/ray/pull/45016/files from this?

[kevin85421]

Would you mind rebasing with the master branch?

[982945902]

Would you mind rebasing with the master branch?

@kevin85421 not mind, how need i do

[kevin85421]

Take a look at your commit history. It seems to be that you don't sync with the master branch correctly. You may not need to rebase with the master branch, but you need to fix your commit history.

[kevin85421]

Hi @982945902, would you mind fixing the CI failure?

[982945902]

@kevin85421 It seems that some of the test cases timed out, causing the use cases to fail, how should I re-triggered the C test

[kevin85421]

It seems that some of the test cases timed out, causing the use cases to fail, how should I re-triggered the C test

I re-triggered CI pipeline multiple times for this PR. It always fails. Could you try to reproduce in your local env?

[982945902]

@kevin85421 These test cases have bugs, and someone merged and fixed them two days ago

[982945902]

@kevin85421 These test cases have bugs, and someone merged and fixed them two days ago

[kevin85421]

Would you mind rebasing with the master branch? Thanks!

[982945902]

Would you mind rebasing with the master branch? Thanks!

@kevin85421 not mind, how need i do

[kevin85421]

@kevin85421 not mind, how need i do

Sync your branch with the upstream master branch.

[982945902]

@kevin85421 done