Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Don't raise batch size error if num_gpus=0 #45202

Merged
merged 1 commit into from
May 8, 2024
Merged

[Data] Don't raise batch size error if num_gpus=0 #45202

merged 1 commit into from
May 8, 2024

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented May 8, 2024 •
edited

Why are these changes needed?

Ray Data raises an error if you use GPUs and don't specify a batch size. However, if you specify num_gpus=0, you still get an error. This PR corrects this confusing behavior.

Related issue number

Fixes #45201

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani
Initial commit
b200d25 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani bveeramani merged commit 3e6b30a into ray-project:master May 8, 2024
5 checks passed
@bveeramani bveeramani deleted the fix-use-gpu branch May 8, 2024 20:31
liuxsh9 pushed a commit to liuxsh9/ray that referenced this pull request May 10, 2024
@bveeramani @liuxsh9
[Data] Don't raise batch size error if num_gpus=0 (ray-project#45202)
e5f4b66 
Ray Data raises an error if you use GPUs and don't specify a batch size. However, if you specify num_gpus=0, you still get an error. This PR corrects this confusing behavior.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
HenryZJY pushed a commit to HenryZJY/ray that referenced this pull request May 10, 2024
@bveeramani @HenryZJY
[Data] Don't raise batch size error if num_gpus=0 (ray-project#45202)
ef50d0d 
Ray Data raises an error if you use GPUs and don't specify a batch size. However, if you specify num_gpus=0, you still get an error. This PR corrects this confusing behavior.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
peytondmurray pushed a commit to peytondmurray/ray that referenced this pull request May 13, 2024
@bveeramani @peytondmurray
[Data] Don't raise batch size error if num_gpus=0 (ray-project#45202)
91411c6 
Ray Data raises an error if you use GPUs and don't specify a batch size. However, if you specify num_gpus=0, you still get an error. This PR corrects this confusing behavior.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
@bveeramani @ryanaoleary
[Data] Don't raise batch size error if num_gpus=0 (ray-project#45202)
dbbc646 
Ray Data raises an error if you use GPUs and don't specify a batch size. However, if you specify num_gpus=0, you still get an error. This PR corrects this confusing behavior.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 6, 2024
@bveeramani @ryanaoleary
[Data] Don't raise batch size error if num_gpus=0 (ray-project#45202)
d7b3144 
Ray Data raises an error if you use GPUs and don't specify a batch size. However, if you specify num_gpus=0, you still get an error. This PR corrects this confusing behavior.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary pushed a commit to ryanaoleary/ray that referenced this pull request Jun 7, 2024
@bveeramani @ryanaoleary
[Data] Don't raise batch size error if num_gpus=0 (ray-project#45202)
2ed31c2 
Ray Data raises an error if you use GPUs and don't specify a batch size. However, if you specify num_gpus=0, you still get an error. This PR corrects this confusing behavior.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
GabeChurch pushed a commit to GabeChurch/ray that referenced this pull request Jun 11, 2024
@bveeramani @GabeChurch
[Data] Don't raise batch size error if num_gpus=0 (ray-project#45202)
879e117 
Ray Data raises an error if you use GPUs and don't specify a batch size. However, if you specify num_gpus=0, you still get an error. This PR corrects this confusing behavior.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: gchurch <gabe1church@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjlee scottjlee scottjlee approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@c21 c21 Awaiting requested review from c21 c21 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees

@scottjlee scottjlee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ray Data] map_batches treats num_gpus=0 as specifying a workload to run on a GPU
2 participants
@bveeramani @scottjlee