-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tune] Improve excessive syncing warning and make some deprecations #45210
Conversation
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
) | ||
if os.environ.get("TUNE_RESULT_DIR"): | ||
warnings.warn(ENV_VAR_DEPRECATION_MESSAGE.format("TUNE_RESULT_DIR")) | ||
raise DeprecationWarning(ENV_VAR_DEPRECATION_MESSAGE.format("TUNE_RESULT_DIR")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first thought is that it might be odd to raise if an environment variable is set, but I'm not sure what the best practice is, so this is probably fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was considering keeping it a warning for another release before just removing it.
Pros:
- No breaking user code
Cons:
- Implicit behavior change that users may be relying on will happen without warning / with no suggested fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…warning_wording
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
w00t I just rebase your PR on top of the latest master to avoid a bug in microcheck, hope you don't mind, thankks |
…ay-project#45210) Make the "Experiment state snapshotting has been triggered multiple..." warning message is less confusing, and remove the false positive log at the end of every run. Also makes some deprecations of `TUNE_RESULT_DIR`, `RAY_AIR_LOCAL_CACHE_DIR`, `local_dir` legacy settings. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
…ay-project#45210) Make the "Experiment state snapshotting has been triggered multiple..." warning message is less confusing, and remove the false positive log at the end of every run. Also makes some deprecations of `TUNE_RESULT_DIR`, `RAY_AIR_LOCAL_CACHE_DIR`, `local_dir` legacy settings. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
…ay-project#45210) Make the "Experiment state snapshotting has been triggered multiple..." warning message is less confusing, and remove the false positive log at the end of every run. Also makes some deprecations of `TUNE_RESULT_DIR`, `RAY_AIR_LOCAL_CACHE_DIR`, `local_dir` legacy settings. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com>
…ay-project#45210) Make the "Experiment state snapshotting has been triggered multiple..." warning message is less confusing, and remove the false positive log at the end of every run. Also makes some deprecations of `TUNE_RESULT_DIR`, `RAY_AIR_LOCAL_CACHE_DIR`, `local_dir` legacy settings. --------- Signed-off-by: Justin Yu <justinvyu@anyscale.com> Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com> Signed-off-by: gchurch <gabe1church@gmail.com>
Why are these changes needed?
This PR makes it so that the "Experiment state snapshotting has been triggered multiple..." warning message is less confusing and does not always trigger at the end of training.
This PR also makes some deprecations:
TUNE_RESULT_DIR
,RAY_AIR_LOCAL_CACHE_DIR
,local_dir
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.