-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] migrate reef test to use test_in_docker #45239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can-anyscale
force-pushed
the
can-citest
branch
8 times, most recently
from
May 10, 2024 04:54
9814a81
to
cc8850e
Compare
can-anyscale
commented
May 10, 2024
yaml_flaky_tests = set(yaml.safe_load(f)["flaky_tests"]) | ||
|
||
# load flaky tests from DB | ||
s3_flaky_tests = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this whole blob is just indented
Signed-off-by: can <can@anyscale.com>
aslonnie
approved these changes
May 10, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
Migrate reef tests to use test_in_docker so that they can be included in microcheck. This PR also: - Add a BUILD_TYPE=skip to skip building ray in test_in_docker - Make the ci.tests.yaml file (that one declares flaky tests per team) optional. I'll working towards deprecating them. Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
Migrate reef tests to use test_in_docker so that they can be included in microcheck. This PR also: - Add a BUILD_TYPE=skip to skip building ray in test_in_docker - Make the ci.tests.yaml file (that one declares flaky tests per team) optional. I'll working towards deprecating them. Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
Migrate reef tests to use test_in_docker so that they can be included in microcheck. This PR also: - Add a BUILD_TYPE=skip to skip building ray in test_in_docker - Make the ci.tests.yaml file (that one declares flaky tests per team) optional. I'll working towards deprecating them. Test: - CI Signed-off-by: can <can@anyscale.com>
GabeChurch
pushed a commit
to GabeChurch/ray
that referenced
this pull request
Jun 11, 2024
Migrate reef tests to use test_in_docker so that they can be included in microcheck. This PR also: - Add a BUILD_TYPE=skip to skip building ray in test_in_docker - Make the ci.tests.yaml file (that one declares flaky tests per team) optional. I'll working towards deprecating them. Test: - CI Signed-off-by: can <can@anyscale.com> Signed-off-by: gchurch <gabe1church@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate reef tests to use test_in_docker so that they can be included in microcheck. This PR also:
Test: