[Data] Refine exception handling from arrow data conversion #45294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-submit ray-project#510 to runtime/master Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
bveeramani,
stephanie-wang and
omatthew98
as code owners
bveeramani
changed the title
c21
approved these changes
May 13, 2024
bveeramani
approved these changes
May 13, 2024
|
cc @aslonnie |
8 tasks
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…ect#45294) * Add detailed info (column name and data repr) for easier debugging in the error message when there is an exception converting data to arrow. * When DelegatingBlockBuilder has inferred pandas type, do not attempt to use pyarrow again. * Thus we'll only raise an exception, when the first row/batch is inferred as arrow, but a following row/batch cannot be converted to arrow. If the first row/batch is inferred as pandas, no exception or warning will occur. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
…ect#45294) * Add detailed info (column name and data repr) for easier debugging in the error message when there is an exception converting data to arrow. * When DelegatingBlockBuilder has inferred pandas type, do not attempt to use pyarrow again. * Thus we'll only raise an exception, when the first row/batch is inferred as arrow, but a following row/batch cannot be converted to arrow. If the first row/batch is inferred as pandas, no exception or warning will occur. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
…ect#45294) * Add detailed info (column name and data repr) for easier debugging in the error message when there is an exception converting data to arrow. * When DelegatingBlockBuilder has inferred pandas type, do not attempt to use pyarrow again. * Thus we'll only raise an exception, when the first row/batch is inferred as arrow, but a following row/batch cannot be converted to arrow. If the first row/batch is inferred as pandas, no exception or warning will occur. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
GabeChurch
pushed a commit
to GabeChurch/ray
that referenced
this pull request
Jun 11, 2024
…ect#45294) * Add detailed info (column name and data repr) for easier debugging in the error message when there is an exception converting data to arrow. * When DelegatingBlockBuilder has inferred pandas type, do not attempt to use pyarrow again. * Thus we'll only raise an exception, when the first row/batch is inferred as arrow, but a following row/batch cannot be converted to arrow. If the first row/batch is inferred as pandas, no exception or warning will occur. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: gchurch <gabe1church@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.