[Data] Add support for using GPUs with map_groups
#45305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani
requested review from
ericl,
scv119,
c21,
amogkam,
scottjlee,
raulchen,
stephanie-wang and
omatthew98
as code owners
9 tasks
raulchen
approved these changes
May 13, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
You can't use GPUs with map_groups. There's no reason you shouldn't be able to do this; it was just was an issue with our implementation. This PR fixes it. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
You can't use GPUs with map_groups. There's no reason you shouldn't be able to do this; it was just was an issue with our implementation. This PR fixes it. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
You can't use GPUs with map_groups. There's no reason you shouldn't be able to do this; it was just was an issue with our implementation. This PR fixes it. Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
GabeChurch
pushed a commit
to GabeChurch/ray
that referenced
this pull request
Jun 11, 2024
You can't use GPUs with map_groups. There's no reason you shouldn't be able to do this; it was just was an issue with our implementation. This PR fixes it. Signed-off-by: Balaji Veeramani <balaji@anyscale.com> Signed-off-by: gchurch <gabe1church@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
You can't use GPUs with
map_groups. There's no reason you shouldn't be able to do this; it was just was an issue with our implementation. This PR fixes it.Related issue number
Fixes #42340
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.