-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Fix stateful module errors with inference only mode. #45465
Merged
sven1977
merged 9 commits into
ray-project:master
from
simonsays1980:fix-stateful-module-errors-with-inference-only-mode
May 22, 2024
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c748df8
Changed comment.
simonsays1980 6409007
Merge branch 'master' of https://github.com/ray-project/ray
simonsays1980 d2f9030
Merge branch 'master' of https://github.com/ray-project/ray
simonsays1980 a3416a8
Merge branch 'master' of https://github.com/ray-project/ray
simonsays1980 8582ad9
Merge branch 'master' of https://github.com/ray-project/ray
simonsays1980 b565f34
Merge branch 'master' of https://github.com/ray-project/ray
simonsays1980 f19120e
Fixed an error that occurred with stateful modules in 'inference-only…
simonsays1980 d4f0e30
LINTER.
simonsays1980 c26298d
Replaced testing for 'use_lstm' with a more generic approach using 'R…
simonsays1980 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also use
is_stateful()
here? What if the user doesn't use the built-in use_lstm option, but comes with their own stateful model?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sven1977 this was my first intend, however at this point in time
is_stateful()
cannot be called, yet b/c the encoder is not yet defined.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is not a nice solution, but at this point in the code we need to know, if the module is stateful or not, but the
is_stateful()
depends on the encoder which is defined depending oninference-only
beingTrue/False
.