[core] log dedup should not dedup number only lines #45485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hongchaodeng <hongchaodeng1@gmail.com>
hongchaodeng
added
the
go
rynewang
reviewed
May 24, 2024
| "ip": "node1", | ||
| "pid": 100, | ||
| # numbers are canonicalised, so this would lead to empty dedup_key | ||
| "lines": ["1"], |
There was a problem hiding this comment.
since we are testing LogDeduplicator can you add more duplicate lines? like 2 then 2 and all are outputed.
rynewang
approved these changes
May 24, 2024
jjyao
approved these changes
May 24, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
Signed-off-by: hongchaodeng <hongchaodeng1@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
Signed-off-by: hongchaodeng <hongchaodeng1@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
Signed-off-by: hongchaodeng <hongchaodeng1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ray runtime in driver deduplicates similar logs from all workers by default. In this case, all numbers are canonicalized, i.e. treated equal.
If all that prints are just numbers, it would be really bad user experience to dedup them. Because that's all the information that users want to see. If they can't see them, they will be confused.
Related issue number
Fix #45262
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.