Clean up Serve proxy files #45486
Merged
Clean up Serve proxy files #45486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamen Shah <kamenshah@gmail.com>
edoakes
reviewed
May 22, 2024
KamenShah
changed the title
Signed-off-by: Kamen Shah <kamenshah@gmail.com>
edoakes
approved these changes
May 22, 2024
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
This PR includes 2 changes: 1. Cleaning up the proxy file to improve consistency for the HTTP and GRPC proxy. 2. Add missing properties to testing classes to better simulate e2e tests. --------- Signed-off-by: Kamen Shah <kamenshah@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 6, 2024
This PR includes 2 changes: 1. Cleaning up the proxy file to improve consistency for the HTTP and GRPC proxy. 2. Add missing properties to testing classes to better simulate e2e tests. --------- Signed-off-by: Kamen Shah <kamenshah@gmail.com> Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
This PR includes 2 changes: 1. Cleaning up the proxy file to improve consistency for the HTTP and GRPC proxy. 2. Add missing properties to testing classes to better simulate e2e tests. --------- Signed-off-by: Kamen Shah <kamenshah@gmail.com>
GabeChurch
pushed a commit
to GabeChurch/ray
that referenced
this pull request
Jun 11, 2024
This PR includes 2 changes: 1. Cleaning up the proxy file to improve consistency for the HTTP and GRPC proxy. 2. Add missing properties to testing classes to better simulate e2e tests. --------- Signed-off-by: Kamen Shah <kamenshah@gmail.com> Signed-off-by: gchurch <gabe1church@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 changes: