[core][2/2] Kill worker on root detached actor died. #45638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #44214 fixes issue that when a job finished, there are workers leaked. However if a worker is assigned to a detached actor, they still leak. This PR fixes this by listening on actor death and kill assigned workers accordingly.
Based on #45637 which adds SubscribeAllActors to GcsClient. This PR uses it in node_manager and kills workers.
node_manager
listens to all actor changes inNodeManager::HandleActorUpdate
, and it kills running workers and invokeworker_pool
callback to bookkeep the died actor.worker_pool
will then kill workers in periodic loops and worker start callbacks.There are several kinds of workers to kill:
NodeManager::leased_workers_
, killed in the subscription callback inNodeManager::HandleActorUpdate
WorkerPool::TryKillingIdleWorkers
->WorkerPool::KillIdleWorker
WorkerPool::PopWorkerCallbackInternal
WorkerPool::InvokePopWorkerCallbackForProcess
...and we treat them accordingly.
Fixes part of #45596.