[core] Add Autoscaler stub methods to GcsClients. #46061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynewang
force-pushed
the
autoscaler-method
branch
from
00f8945
to
e668e4c
Compare
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
rynewang
force-pushed
the
autoscaler-method
branch
from
e668e4c
to
57ae290
Compare
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
ruisearch42
reviewed
Jun 18, 2024
| }, \ | ||
| timeout_ms); \ | ||
| return promise.get_future().get(); \ | ||
| #define VOID_GCS_RPC_CLIENT_METHOD_FULL(NAMESPACE, \ |
There was a problem hiding this comment.
Could you add some documentation?
Comment on lines
+898
to
+911
| virtual Status RequestClusterResourceConstraint( | ||
| int64_t timeout_ms, | ||
| const std::vector<std::unordered_map<std::string, double>> &bundles, | ||
| const std::vector<int64_t> &count_array); | ||
|
|
||
| virtual Status GetClusterResourceState(int64_t timeout_ms, | ||
| std::string &serialized_reply); | ||
|
|
||
| virtual Status GetClusterStatus(int64_t timeout_ms, std::string &serialized_reply); | ||
|
|
||
| virtual Status ReportAutoscalingState(int64_t timeout_ms, | ||
| const std::string &serialized_state); | ||
|
|
||
| virtual Status DrainNode(const std::string &node_id, |
There was a problem hiding this comment.
Could you please add documentation?
| request, &reply, timeout_ms); | ||
| } | ||
|
|
||
| Status AutoscalerStateAccessor::DrainNode(const std::string &node_id, |
There was a problem hiding this comment.
(Same for other methods) There are quite some code duplication with PythonGcsClient::DrainNode(). I know eventually we want to replace PythonGcsClient. But in the interim, is it possible to extract common code and invoke it from both? Wondering if we could avoid code diverging in the two places.
There was a problem hiding this comment.
I guess we are deleting the PythonGcsClient ones really quick so it's not that beneficial to do common functions with 2 wrappers.
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ray::rpc::autoscaler::AutoscalerStateService is on GCS, accessible via PythonGcsClient but not via GcsClient. This PR adds all methods and brings feature parity for the latter.
In order to add it to GcsRpcClient, we find 2 challenges:
statusfield like all other replies.To support this, I changed
VOID_GCS_RPC_CLIENT_METHODto a more generic versionVOID_GCS_RPC_CLIENT_METHOD_FULLthat accepts a namespace and a booleanhandle_payload_status. The boolean is passed toinvoke_async_methodin compile time. This allows us to only checkstatusfield if the bool is true, and don't check it for the new autoscaler methods.The GcsClient methods are only added with sync version and not async version, because the callers only need sync ones.