Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] [Release] Enable full Ray Data stack trace for release tests #46128

Merged
merged 3 commits into from
Jun 20, 2024
Merged

[Data] [Release] Enable full Ray Data stack trace for release tests #46128

merged 3 commits into from
Jun 20, 2024

Conversation

scottjlee
Copy link
Contributor

@scottjlee scottjlee commented Jun 18, 2024 •
edited
Loading

Why are these changes needed?

Ray Data added a feature which suppresses internal stack trace upon a user code error (#43251). Similar to #46101 which enables full stack traces when running unit tests, this PR enables full stack traces for release test runs.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy

@scottjlee
enable full strack trace for release tests
771311b 
Signed-off-by: Scott Lee <sjl@anyscale.com>
@scottjlee scottjlee marked this pull request as ready for review June 18, 2024 19:54
@scottjlee scottjlee requested a review from a team as a code owner June 18, 2024 19:54
can-anyscale
can-anyscale approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@can-anyscale can-anyscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bveeramani bveeramani enabled auto-merge (squash) June 19, 2024 00:39
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jun 19, 2024
@scottjlee
Merge branch 'master' into 0618-rt-logs
9cff2dc 
Signed-off-by: Scott Lee <sjl@anyscale.com>
@scottjlee
update test
beb4180 
Signed-off-by: Scott Lee <sjl@anyscale.com>
@github-actions github-actions bot disabled auto-merge June 20, 2024 19:13
@can-anyscale can-anyscale merged commit af30098 into ray-project:master Jun 20, 2024
6 checks passed
KyleKoon pushed a commit to KyleKoon/ray that referenced this pull request Jul 22, 2024
@scottjlee @kkoon1
[Data] [Release] Enable full Ray Data stack trace for release tests (r…
d2c74c3 
…ay-project#46128)

Ray Data added a feature which suppresses internal stack trace upon a user code error (ray-project#43251). Similar to ray-project#46101 which enables full stack traces when running unit tests, this PR enables full stack traces for release test runs.

Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: kkoon <kkoon@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bveeramani bveeramani bveeramani approved these changes

@can-anyscale can-anyscale can-anyscale approved these changes

Assignees

@bveeramani bveeramani

@can-anyscale can-anyscale

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scottjlee @bveeramani @can-anyscale