Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MADDPG implementation in RLlib #5348

Merged
merged 20 commits into from Aug 6, 2019
Merged

MADDPG implementation in RLlib #5348

merged 20 commits into from Aug 6, 2019

Conversation

wsjeon
Copy link
Contributor

@wsjeon wsjeon commented Aug 1, 2019

What do these changes do?

I refactored OpenAI/MADDPG implementation in RLlib and checked the performance.

Related issue number

Closes #4654

Linter

  • I've run scripts/format.sh to lint the changes in this PR.

@ericl
Copy link
Contributor

ericl commented Aug 1, 2019

Thanks, this looks pretty good. Would it be possible to include some runnable example script so that we can run them in Jenkins, and so that users can try it out of the box?

@ericl ericl self-assigned this Aug 1, 2019
@wsjeon
Copy link
Contributor Author

wsjeon commented Aug 1, 2019 via email

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/15910/
Test FAILed.

Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I pushed some changes to add the twostep_game test, remove the need for obs_space_dict / act_space_dict, and move it to contrib/MADDPG.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16007/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16016/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16018/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16034/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16041/
Test FAILed.

@ericl ericl merged commit 281829e into ray-project:master Aug 6, 2019
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/16057/
Test PASSed.

edoakes pushed a commit to edoakes/ray that referenced this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rllib] Implement MA-DDPG as another multi-agent algorithm example
3 participants