Add retries in dynamic resource test cases #5550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases where resource state query from the tests happen before the GCS/heartbeat updates.
romilbhardwaj
commented
Aug 27, 2019
| if condition(): | ||
| return True | ||
| time.sleep(SLEEP_DURATION) | ||
| time_elapsed += SLEEP_DURATION |
There was a problem hiding this comment.
I extracted this method from test_release_cpus_when_actor_creation_task_blocking, but I'm not sure if this is the best way to check for a timeout. Should we be using time_elapsed = time.time() - start_time? Otherwise this is equivalent to having a fixed number of retries.
|
Test PASSed. |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Some of the dynamic resource test cases fail intermittently with
KeyErrorwhen queryingray.available_resources()orray.available_resources(). I believe this happens in rare cases when there are delays in GCS updates/heartbeat propagation and the test ends up querying the resource state before it has been updated.As a fix, this PR adds a retry-timeout mechanism which retries the assertion condition until a short timeout elapses.
Linter
scripts/format.shto lint the changes in this PR.