Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch grpc for Windows #6282

Merged
merged 1 commit into from Nov 26, 2019
Merged

Patch grpc for Windows #6282

merged 1 commit into from Nov 26, 2019

Conversation

mehrdadn
Copy link
Contributor

@mehrdadn mehrdadn commented Nov 26, 2019

Why are these changes needed?

Need quoting to avoid splitting on spaces in file path.

Related issue number

#631

grpc/grpc#20820

Checks

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@simon-mo
Copy link
Contributor

Should we consider using appveyor or azure pipeline to add windows into our CI? (cc @pcmoritz)

@mehrdadn
Copy link
Contributor Author

Yes, but I'm not familiar with either, so I don't know what the trade-offs are. If you guys have details I might able to help with making a choice.

@robertnishihara
Copy link
Collaborator

@simon-mo @mehrdadn, last time I discussed this with @pcmoritz, GitHub actions seemed like a good option to explore (or potentially Azure pipelines).

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/18916/
Test PASSed.

@pcmoritz pcmoritz merged commit 82d1788 into ray-project:master Nov 26, 2019
@mehrdadn mehrdadn deleted the grpc-patch branch November 26, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants