[Java] Fix instanceof RayPyActor
#6377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
zhijunfu
approved these changes
Dec 6, 2019
raulchen
reviewed
Dec 6, 2019
| @@ -37,7 +37,7 @@ public RayActor createActor(FunctionDescriptor functionDescriptor, List<Function | |||
| ActorCreationOptions options) { | |||
| byte[] actorId = nativeCreateActor(nativeCoreWorkerPointer, functionDescriptor, args, | |||
| options); | |||
| return new NativeRayActor(nativeCoreWorkerPointer, actorId); | |||
| return NativeRayActor.create(nativeCoreWorkerPointer, actorId); | |||
There was a problem hiding this comment.
We can tell the language from functionDescriptor, so it's not necessary to look up the language again in C++ (nativeGetLanguage).
There was a problem hiding this comment.
Good point. I've updated the code and removed nativeGetLanguage.
|
Test FAILed. |
|
Test PASSed. |
raulchen
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
For a Java actor, the
instanceof RayPyActorshould befalse. This is a bug introduced in #5370.Related issue number
Checks
scripts/format.shto lint the changes in this PR.