Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky distributed array test #7713

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

stephanie-wang
Copy link
Contributor

@stephanie-wang stephanie-wang commented Mar 23, 2020

Why are these changes needed?

test_array.py::test_distributed_array_methods has been timing out occasionally. This happens when plasma store notifications to the raylet for new objects get delayed. If the delay is long enough, then this causes concurrent fetch calls to timeout and mistakenly mark the object as lost. This PR sets the timeout very high in this particular test to prevent the spurious error. Confirmed locally that this fixes the flaky test.

It's unclear exactly when this has been coming up. It seems more likely to happen if the plasma store or raylet have more load, since then the notifications will not get processed by the raylet quickly enough. The errors may have been exacerbated by #7628 but I'm not sure why.

Checks

Copy link
Contributor

@edoakes edoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Curious why it only seems to come up on this specific test. Were you able to reproduce it locally?

@stephanie-wang
Copy link
Contributor Author

Interesting. Curious why it only seems to come up on this specific test. Were you able to reproduce it locally?

Yes, it flaked out in <10 runs when run locally with all of the processes pinned to 1 core. I'd guess that it comes up more in this test because it uses plasma and distributed references heavily. Which makes it a good test, I suppose :)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23591/
Test FAILed.

@stephanie-wang stephanie-wang merged commit 7f38cc1 into ray-project:master Mar 23, 2020
@stephanie-wang stephanie-wang deleted the fix-array branch March 23, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants