Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Don't warn if we're waiting for workers to start #8810

Closed
wants to merge 2 commits into from
Closed

[core] Don't warn if we're waiting for workers to start #8810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d8806a
suppress warning
ericl Jun 5, 2020
52061ce
Update node_manager.cc
ericl Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/ray/raylet/node_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,12 @@ void NodeManager::DoLocalGC() {
// debug_dump_period_ milliseconds.
// See https://github.com/ray-project/ray/issues/5790 for details.
void NodeManager::WarnResourceDeadlock() {
if (local_queues_.GetTasks(TaskState::RUNNING).empty()) {
// No tasks running at all, don't warn. Probably we are just waiting for
// workers to start and join the pool.
resource_deadlock_warned_ = false;
return;
}
// Check if any progress is being made on this raylet.
for (const auto &task : local_queues_.GetTasks(TaskState::RUNNING)) {
// Ignore blocked tasks.
Expand Down