Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Fix long running failure test #8863

Merged
merged 1 commit into from
Jun 9, 2020
Merged

[serve] Fix long running failure test #8863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions ci/long_running_tests/workloads/serve_failure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

import ray
from ray import serve
from ray.serve.utils import retry_actor_failures
from ray.cluster_utils import Cluster

num_redis_shards = 1
Expand Down Expand Up @@ -42,11 +41,10 @@ def __init__(self, kill_period_s=1):

def _get_all_serve_actors(self):
master = serve.api._get_master_actor()
[router] = retry_actor_failures(master.get_router)
[http_proxy] = retry_actor_failures(master.get_http_proxy)
[router] = ray.get(master.get_router.remote())
[http_proxy] = ray.get(master.get_http_proxy.remote())
all_handles = [master, router, http_proxy]
worker_handle_dict = retry_actor_failures(
master.get_all_worker_handles)
worker_handle_dict = ray.get(master.get_all_worker_handles.remote())
for _, replica_dict in worker_handle_dict.items():
all_handles.extend(list(replica_dict.values()))

Expand Down