Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more Windows issues #9011

Merged
merged 5 commits into from Jun 20, 2020
Merged

Fix more Windows issues #9011

merged 5 commits into from Jun 20, 2020

Conversation

mehrdadn
Copy link
Contributor

@mehrdadn mehrdadn commented Jun 18, 2020 •
edited

Why are these changes needed?

Addresses more Windows issues:

  • conftest.py not found

  • os.path.join to handle separators

  • check_call instead of check_output when output should go to terminal

  • Avoid null pointer in PlasmaStoreRunner::Stop

Related issue number

#631

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27291/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27297/
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27318/
Test FAILed.

@mehrdadn mehrdadn force-pushed the windows-tests branch 2 times, most recently from c7c6b71 to e8765d2 Compare June 19, 2020 03:10
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27322/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27323/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27338/
Test FAILed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27341/
Test PASSed.

@mehrdadn mehrdadn marked this pull request as ready for review June 19, 2020 23:18
@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/27349/
Test PASSed.

robertnishihara
robertnishihara reviewed Jun 20, 2020
View reviewed changes
src/ray/object_manager/plasma/store_runner.cc
@@ -133,7 +133,11 @@ void PlasmaStoreRunner::Start() {
ArrowLog::ShutDownArrowLog();
}

void PlasmaStoreRunner::Stop() { loop_->Stop(); }
void PlasmaStoreRunner::Stop() {
if (loop_) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When can this happen (where the if is needed)?

Copy link
Contributor Author

@mehrdadn mehrdadn Jun 20, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the cause yet, but it happens on my machine on Windows.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's a bug. Can you document that there is a bug here and that this is a workaround but we don't understand why it is necessary (along with instructions for how to reproduce it)?

@simon-mo simon-mo merged commit 981f67b into ray-project:master Jun 20, 2020
@mehrdadn mehrdadn deleted the windows-tests branch June 20, 2020 01:55
@mehrdadn mehrdadn mentioned this pull request Jun 21, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertnishihara robertnishihara robertnishihara left review comments

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mehrdadn @AmplabJenkins @robertnishihara @simon-mo @web-flow