This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
Change BaseEstimator to BaseSearchCV #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Travis CI fails on linux with an optuna error
And on mac on ray with:
I checked travis, and it these exact two errors also occured previously on the master branch (https://travis-ci.com/github/ray-project/tune-sklearn/builds/219073636). So it seems the build was already failing before this PR. |
|
All that matters is that github actions pass, Travis is a bit outdated |
|
Cc @richardliaw |
Yard1
approved these changes
Mar 9, 2021
|
Any plans on an upcoming patch release ? ;) |
|
Sure! Let me put it on my sprint. |
Closed
|
Sorry for the delay! @timvink release is done :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses ray-project/ray#14534.