This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
Pass estimators via object store IDs #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krfricke
commented
Mar 12, 2021
| @@ -43,7 +42,8 @@ def _setup(self, config): | |||
| stopping if it is set to true. | |||
|
|
|||
| """ | |||
| self.estimator_list = clone(config.pop("estimator_list")) | |||
| estimator_ids = list(config.pop("estimator_ids")) | |||
| self.estimator_list = ray.get(estimator_ids) | |||
There was a problem hiding this comment.
This implicitly clones the estimators
Yard1
approved these changes
Mar 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently estimator objects are passed via the
configparameter (as is the data). However, in some cases this can lead to unexpected errors when creating the search space with Hyperopt.By passing the estimators via the object store we circumvent this problem.
After the next release we might want to use
tune.with_parameters()to avoid passing anything other than the search space via the config parameter, see ray-project/ray#14532Closes #186