This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
Allow 1 as sk_n_jobs, fix cloning issues
#225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yard1
changed the title
sk_n_jobs, remove kwargssk_n_jobs, fix cloning issues
xwjiang2010
approved these changes
Oct 18, 2021
xwjiang2010
reviewed
Oct 18, 2021
| @@ -8,7 +8,7 @@ ROOT="$(git rev-parse --show-toplevel)" | |||
| builtin cd "$ROOT/examples" | |||
| PYTHON="${PYTHON:-python}" | |||
| # rm catboostclassifier.py | |||
| rm bohb_example.py hpbandster_sgd.py # Temporary hack to avoid breaking CI | |||
| rm keras_example.py # Keras example crashes randomly | |||
There was a problem hiding this comment.
Do you know why? Should we track re-enabling it?
There was a problem hiding this comment.
Not sure why, and I couldn't reproduce it locally. Perhaps it's running out of memory on the small github runner. I'll open an issue to track it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #221