This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
Import mlflow integration from new air.integrations module
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Yard1
approved these changes
May 25, 2023
|
Actually, can we have a try...except import here? @justinvyu |
|
I think the MLFlowLoggerCallback already try catches if mlflow is not installed. |
8 tasks
|
@Yard1 by try/except do you mean something like:
|
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
|
No need to try catch since tune_sklearn depends on ray>=2.0, and the module was already moved to air.integrations at 2.0. Relaunching the CI, then we can merge after it passes. |
|
CI for latest Ray release is failing due to a fix that did not make the branch cut but will be fixed on 2.6. CI for master is failing due to a similar issue as this flaky example on ray: ray-project/ray#35428 |
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: Justin Yu <justinvyu@anyscale.com>
|
Passing with master wheel here: https://github.com/ray-project/tune-sklearn/actions/runs/5426940588/jobs/9869633497 |
This reverts commit e408ed8. Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Yard1
approved these changes
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ray has some unit-tests depending on this package. The
ray.tune.integrationpackage is getting hard-deprecated in Ray 2.6, so this needs package needs to import from the new location atray.air.integrationsto unblock that.In particular, it's this user guide doctest that would fail: https://docs.ray.io/en/latest/tune/examples/tune-sklearn.html