Tune checkpointing #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
December 1, 2020 12:01
# Conflicts: # examples/simple.py # examples/simple_tune.py # xgboost_ray/main.py # xgboost_ray/tests/release/benchmark_cpu_gpu.py # xgboost_ray/tests/test_fault_tolerance.py # xgboost_ray/tests/utils.py
|
Actually you can wait to review this PR until #20 is merged |
richardliaw
reviewed
Dec 2, 2020
|
I believe this PR also depends on ray-project/ray#12572. |
|
Updated PR following the discussion on ray-project/ray#12572 With this replace mechanism, I'll likely add some unit tests to make sure this works as expected. |
added 16 commits
December 7, 2020 11:08
# Conflicts: # xgboost_ray/main.py
|
Ready again for reviews @amogkam @richardliaw |
Merged
amogkam
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from custom checkpointing callback to ray-supplied callbacks.
Depends on #20