Switch to use packaging.Version from distutils LooseVersion #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peytondmurray
force-pushed
the
deprecate-distutils
branch
from
8ef6834
to
48ae22d
Compare
Yard1
approved these changes
Sep 1, 2022
Definitely, I'll take a look later today! Looks like there's a formatting issue - I'll run the formatter and push again. |
Signed-off-by: pdmurray <peynmurray@gmail.com>
peytondmurray
force-pushed
the
deprecate-distutils
branch
from
48ae22d
to
ea0fb9a
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes uses of
distutils.version.LooseVersionin favor ofpackaging.version.Versionat the suggestion of the deprecation warning generated when a user makes use ofLooseVersion. This PR addresses one of the deprecation warnings identified in ray-project/ray#27851.distutilswill be deprecated in Python 3.10 and 3.11, and removed entirely in 3.12.Changes
distutils.version.Versionwithpackaging.version.Versioneverywherepackagingas a dependency inrequirements-test.txtand insetup.pyTests
I tested this on my local machine with
pytestand all the tests that weren't skipped passed.